Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] Allow presets to be objects #5385

Merged
merged 2 commits into from Feb 28, 2017
Merged

[7.0] Allow presets to be objects #5385

merged 2 commits into from Feb 28, 2017

Conversation

@danez
Copy link
Member

danez commented Feb 27, 2017

Q A
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? y
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets
License MIT
Doc PR
Dependency Changes
@danez danez added this to the Babel 7 milestone Feb 27, 2017
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 27, 2017

Codecov Report

Merging #5385 into 7.0 will increase coverage by 0.11%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##              7.0    #5385      +/-   ##
==========================================
+ Coverage   85.25%   85.37%   +0.11%     
==========================================
  Files         204      204              
  Lines        9565     9551      -14     
  Branches     2693     2693              
==========================================
- Hits         8155     8154       -1     
+ Misses        919      906      -13     
  Partials      491      491
Impacted Files Coverage Δ
.../src/transformation/file/options/option-manager.js 83.62% <85.71%> (+0.14%)
packages/babel-core/src/index.js 58.82% <0%> (-7.85%)
...ckages/babel-core/src/transformation/file/index.js 84.98% <0%> (-0.06%)
packages/babel-traverse/src/path/context.js 86.2% <0%> (ø)
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.59% <0%> (+0.42%)
packages/babel-traverse/src/path/modification.js 74.75% <0%> (+0.97%)
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%)
packages/babel-core/src/transformation/pipeline.js 63.15% <0%> (+21.77%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 696e63c...f85fef9. Read the comment docs.

@xtuc
xtuc approved these changes Feb 28, 2017
@hzoo hzoo requested a review from loganfsmyth Feb 28, 2017
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Feb 28, 2017

Awesome, thanks @danez!

@hzoo hzoo merged commit 6d6cdf6 into babel:7.0 Feb 28, 2017
3 checks passed
3 checks passed
codecov/patch 85.71% of diff hit (target 85.25%)
Details
codecov/project 85.37% (+0.11%) compared to 696e63c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danez danez deleted the danez:allo-object branch Mar 1, 2017
nitin42 added a commit to nitin42/babel that referenced this pull request Mar 14, 2017
* Allow presets to be objects

* Improve logic to detect preset format
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.