Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'resolve' from npm instead of private 'module' methods. #5416

Merged
merged 1 commit into from Mar 7, 2017

Conversation

@loganfsmyth
Copy link
Member

loganfsmyth commented Mar 3, 2017

Q A
Patch: Bug Fix? N
Major: Breaking Change? N
Minor: New Feature?
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets Fixes #1, Fixes #2
License MIT
Doc PR
Dependency Changes

The old code was using a private API and is real gross.

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Mar 3, 2017

@loganfsmyth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @skevy and @motiz88 to be potential reviewers.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 3, 2017

Codecov Report

Merging #5416 into 7.0 will decrease coverage by -0.05%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##              7.0   #5416      +/-   ##
=========================================
- Coverage   85.35%   85.3%   -0.05%     
=========================================
  Files         203     203              
  Lines        9543    9529      -14     
  Branches     2691    2689       -2     
=========================================
- Hits         8145    8129      -16     
- Misses        909     912       +3     
+ Partials      489     488       -1
Impacted Files Coverage Δ
...-helper-transform-fixture-test-runner/src/index.js 86.13% <100%> (-0.53%)
packages/babel-core/src/helpers/resolve.js 100% <100%> (+7.69%)
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%)
packages/babel-traverse/src/path/modification.js 73.78% <0%> (-0.98%)
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.17% <0%> (-0.43%)
packages/babel-traverse/src/path/context.js 86.2% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e2d88...f1ce1c2. Read the comment docs.

@loganfsmyth loganfsmyth merged commit 39eca84 into babel:7.0 Mar 7, 2017
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 85.35%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +14.64% compared to 11e54a6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:remove-module-resolve branch Mar 7, 2017
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Mar 7, 2017

😍 this was gross yeah

@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.