Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unused lodash dep from babel-helper-builder-react-jsx #5484

Merged
merged 1 commit into from Mar 16, 2017

Conversation

@segphault
Copy link
Contributor

segphault commented Mar 16, 2017

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? no
Fixed Tickets Fixes #5482
License MIT
Doc PR no
Dependency Changes Removes unused lodash dependency

Removed an unused dependency on lodash from the package.json file for babel-helper-builder-react-jsx.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Mar 16, 2017

I got rid of the quotes to make it link/close when merged

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 16, 2017

Codecov Report

Merging #5484 into 7.0 will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              7.0    #5484      +/-   ##
==========================================
- Coverage   85.37%   85.33%   -0.05%     
==========================================
  Files         202      202              
  Lines        9528     9528              
  Branches     2703     2703              
==========================================
- Hits         8135     8131       -4     
- Misses        904      908       +4     
  Partials      489      489
Impacted Files Coverage Δ
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%)
packages/babel-traverse/src/path/modification.js 73.78% <0%> (-0.98%)
packages/babel-traverse/src/path/context.js 85.34% <0%> (-0.87%)
...bel-plugin-transform-es2015-classes/src/vanilla.js 89.74% <0%> (-0.43%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf2c76...d5e657d. Read the comment docs.

@hzoo hzoo merged commit 4e96a2d into babel:7.0 Mar 16, 2017
2 of 3 checks passed
2 of 3 checks passed
codecov/project 85.33% (-0.05%) compared to edf2c76
Details
codecov/patch Coverage not affected when comparing edf2c76...d5e657d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@segphault segphault deleted the segphault:patch-1 branch Mar 16, 2017
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Mar 16, 2017

Thanks! this is targeting 7.0, so we'll need to backport if we do another patch

@hzoo hzoo added the 6.x: backport label Mar 16, 2017
@danez

This comment has been minimized.

Copy link
Member

danez commented Mar 16, 2017

Is it also unused in master or only in 7.0?

This is awesome, thanks @segphault

@segphault

This comment has been minimized.

Copy link
Contributor Author

segphault commented Mar 16, 2017

Looks like this could also be done in master. Should I file another pull request?

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Mar 16, 2017

Yeah if you want it before we release (more urgent) then yes

@hzoo hzoo removed the 6.x: backport label Mar 16, 2017
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.