New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add individual polyfill files #5584

Merged
merged 3 commits into from Apr 5, 2017

Conversation

Projects
None yet
3 participants
@hzoo
Member

hzoo commented Apr 4, 2017

It's weird to have the transform for babel-preset-env useBuiltIns change the require

In

import "babel-polyfill";

Out (current)

import "core-js/modules/es7.string.pad-start";
import "core-js/modules/es7.string.pad-end";

With this we can change it to be something like

import "babel-polyfill/core-js/modules/es7.string.pad-end";
import "babel-polyfill/regenerator-runtime/runtime";

Which just appends the path to babel-polyfill

import "babel-polyfill/es7.string.pad-start";
import "babel-polyfill/es2016.string.pad-start"; // or
import "babel-polyfill/string.pad-start"; // or
otherwise just recommend using core-js directly and transforming that.

hzoo added some commits Apr 4, 2017

hzoo added a commit to babel/babel-preset-env that referenced this pull request Apr 4, 2017

Breaking: account for babel/babel#5584, only run on babel-polyfill no…
…t core-js

return babel-polyfill require instead of core-js
@danez

danez approved these changes Apr 5, 2017

@codecov

This comment has been minimized.

codecov bot commented Apr 5, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (7.0@7ad697c). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##             7.0    #5584   +/-   ##
======================================
  Coverage       ?   84.71%           
======================================
  Files          ?      287           
  Lines          ?     9598           
  Branches       ?     2704           
======================================
  Hits           ?     8131           
  Misses         ?      971           
  Partials       ?      496
Impacted Files Coverage Δ
...src/core-js/modules/es6.number.max-safe-integer.js 0% <0%> (ø)
...abel-polyfill/src/core-js/modules/es6.math.cbrt.js 0% <0%> (ø)
...bel-polyfill/src/core-js/modules/es6.array.find.js 0% <0%> (ø)
...yfill/src/core-js/modules/es6.number.is-integer.js 0% <0%> (ø)
...fill/src/core-js/modules/es6.typed.array-buffer.js 0% <0%> (ø)
...yfill/src/core-js/modules/es6.typed.int16-array.js 0% <0%> (ø)
...lyfill/src/core-js/modules/es6.number.is-finite.js 0% <0%> (ø)
...babel-polyfill/src/core-js/modules/es6.weak-map.js 0% <0%> (ø)
...-polyfill/src/core-js/modules/es6.function.name.js 0% <0%> (ø)
...-polyfill/src/core-js/modules/es6.object.assign.js 0% <0%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad697c...dbf075e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment