New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function name to spec-transformed arrow functions #5620

Merged
merged 4 commits into from May 3, 2017

Conversation

Projects
None yet
6 participants
@Kovensky
Member

Kovensky commented Apr 10, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? yes
Deprecations? no
Spec Compliancy? yes
Tests Added/Pass? yes
Fixed Tickets ?
License MIT
Doc PR
Dependency Changes

While it may appear that this should be done by es2015-function-name,
another way to think about it is that es2015-function-name implements
the naming that javascript engines are supposed to do; and javascript
engines cannot name function expressions that are the object of a
member expression.

Add function name to spec-transformed arrow functions
While it may appear that this should be done by es2015-function-name,
another way to think about it is that es2015-function-name implements
the naming that javascript engines are supposed to do; and javascript
engines cannot name function expressions that are the object of a
member expression.
@mention-bot

This comment has been minimized.

mention-bot commented Apr 10, 2017

@Kovensky, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo and @existentialism to be potential reviewers.

@babel-bot

This comment has been minimized.

Collaborator

babel-bot commented Apr 10, 2017

Hey @Kovensky! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@codecov

This comment has been minimized.

codecov bot commented Apr 10, 2017

Codecov Report

Merging #5620 into 7.0 will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              7.0   #5620      +/-   ##
=========================================
+ Coverage   84.59%   84.6%   +0.01%     
=========================================
  Files         283     283              
  Lines        9738    9740       +2     
  Branches     2734    2735       +1     
=========================================
+ Hits         8238    8241       +3     
+ Misses        987     986       -1     
  Partials      513     513
Impacted Files Coverage Δ
...ugin-transform-es2015-arrow-functions/src/index.js 93.33% <100%> (+1.02%) ⬆️
packages/babel-traverse/src/visitors.js 86.66% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c307bbb...1039660. Read the comment docs.

export default function ({ types: t }) {
// @flow
import nameFunction from "babel-helper-function-name";

This comment has been minimized.

@loganfsmyth

loganfsmyth Apr 12, 2017

Member

Looks like we need this in package.json?

This comment has been minimized.

@Kovensky

Kovensky Apr 13, 2017

Member

Hm, probably.

Would be nice if lerna could take care of it 😄

@loganfsmyth

This comment has been minimized.

Member

loganfsmyth commented Apr 12, 2017

LGTM otherwise.

@xtuc

This comment has been minimized.

Member

xtuc commented Apr 13, 2017

@hzoo

This comment has been minimized.

Member

hzoo commented May 1, 2017

We don't have an example for spec mode, did you mean we should add one @xtuc? Do you want to add it and squash merge?

@hzoo hzoo requested a review from xtuc May 1, 2017

@xtuc

This comment has been minimized.

Member

xtuc commented May 2, 2017

I would like to add an example for spec mode but I will probably do a separate PR.

@Kovensky Kovensky merged commit 86a5377 into 7.0 May 3, 2017

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.6% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Kovensky Kovensky deleted the spec-arrow/add-function-name branch May 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment