Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-babelrc option in babel-node #5621

Merged
merged 6 commits into from May 23, 2018

Conversation

@xtuc
Copy link
Member

xtuc commented Apr 10, 2017

Q A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? y
Deprecations?
Spec Compliancy?
Tests Added/Pass? y/y
Fixed Tickets #5616
License MIT
Doc PR
Dependency Changes

Once merged I will make the corresponding documentation changes on the website (in a 7 branch)

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Apr 10, 2017

@xtuc, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @loganfsmyth to be potential reviewers.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 10, 2017

Codecov Report

Merging #5621 into 7.0 will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5621      +/-   ##
==========================================
- Coverage   84.45%   84.43%   -0.02%     
==========================================
  Files         285      285              
  Lines        9648     9649       +1     
  Branches     2711     2711              
==========================================
- Hits         8148     8147       -1     
- Misses        998     1001       +3     
+ Partials      502      501       -1
Impacted Files Coverage Δ
packages/babel-cli/src/_babel-node.js 73.61% <100%> (+1.78%) ⬆️
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%) ⬇️
packages/babel-traverse/src/path/context.js 84.48% <0%> (-1.73%) ⬇️
packages/babel-traverse/src/path/modification.js 73.78% <0%> (-0.98%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.17% <0%> (ø) ⬆️
packages/babel-traverse/src/visitors.js 86.66% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ea3338...ce2d133. Read the comment docs.

@@ -0,0 +1,3 @@
{

This comment has been minimized.

Copy link
@loganfsmyth

loganfsmyth Apr 12, 2017

Member

I'm surprised this isn't inside in-files. Same for the plugin. I think if you move them in there you'd be able to use ./logPlugin.js?

This comment has been minimized.

Copy link
@xtuc

xtuc Apr 13, 2017

Author Member

Yes, that works.

@@ -39,7 +39,9 @@ const readDir = function (loc, filter) {

const saveInFiles = function (files) {
// Place an empty .babelrc in each test so tests won't unexpectedly get to repo-level config.
outputFileSync(".babelrc", "{}");
if (!fs.existsSync(".babelrc")) {

This comment has been minimized.

Copy link
@loganfsmyth

loganfsmyth Apr 12, 2017

Member

This doesn't seem needed. This line is above the files loop because then those will overwrite it if there is one in the test.

This comment has been minimized.

Copy link
@xtuc

xtuc Apr 13, 2017

Author Member

Yes I removed it because it wasn't needed.

xtuc added 2 commits Apr 13, 2017
@danez danez closed this Aug 31, 2017
@danez danez reopened this Aug 31, 2017
@danez danez changed the base branch from 7.0 to master Aug 31, 2017
@loganfsmyth

This comment has been minimized.

Copy link
Member

loganfsmyth commented May 23, 2018

@xtuc Oh just saw this after posting #8010, if you want to rebase this to fix the conflict, I can update my after this is landed.

xtuc added 3 commits May 23, 2018
…abel-node
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented May 23, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8134/

@xtuc

This comment has been minimized.

Copy link
Member Author

xtuc commented May 23, 2018

Ok @loganfsmyth everything is fine again, feel free to merge it

@loganfsmyth loganfsmyth merged commit 52b800d into babel:master May 23, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.73% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xtuc xtuc deleted the xtuc:feat-no-babelrc-babel-node branch May 23, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.