Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect property ordering with obj rest spread on nested #5685

Merged
merged 1 commit into from May 2, 2017
Merged

Conversation

@existentialism
Copy link
Member

existentialism commented May 1, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? yes/yes
Fixed Tickets Fixes #5629
License MIT
Doc PR
Dependency Changes
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented May 1, 2017

@existentialism, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @erikdesjardins and @loganfsmyth to be potential reviewers.

@codecov

This comment has been minimized.

Copy link

codecov bot commented May 1, 2017

Codecov Report

Merging #5685 into 7.0 will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5685      +/-   ##
==========================================
+ Coverage   84.55%   84.58%   +0.02%     
==========================================
  Files         283      283              
  Lines        9733     9735       +2     
  Branches     2732     2732              
==========================================
+ Hits         8230     8234       +4     
+ Misses        990      988       -2     
  Partials      513      513
Impacted Files Coverage Δ
...l-plugin-transform-object-rest-spread/src/index.js 98.37% <100%> (+0.05%) ⬆️
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
packages/babel-traverse/src/path/lib/hoister.js 90.9% <0%> (-0.19%) ⬇️
packages/babel-traverse/src/path/context.js 85.34% <0%> (ø) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.59% <0%> (+0.42%) ⬆️
packages/babel-traverse/src/path/modification.js 74.75% <0%> (+0.97%) ⬆️
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3e8cc8...da5e355. Read the comment docs.

@hzoo
hzoo approved these changes May 1, 2017
Copy link
Member

hzoo left a comment

Should we make a test for another level of nesting?

@existentialism existentialism force-pushed the issue5629 branch from 8b55a58 to da5e355 May 1, 2017
@hzoo hzoo requested a review from loganfsmyth May 1, 2017
@hzoo hzoo merged commit 79c1eed into 7.0 May 2, 2017
4 checks passed
4 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.58% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@existentialism existentialism deleted the issue5629 branch May 2, 2017
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
* 'master' of github.com:hulkish/babel: (190 commits)
  Fix incorrect property ordering with obj rest spread on nested (babel#5685)
  Fix PathHoister hoisting before a same-scope variable declaration.
  Updated transform-react-display-name for createReactClass addon (babel#5554)
  Fix PathHoister error attaching after export declarations.
  add .mjs to list of well known extensions
  Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676)
  use find-cache-dir for babel-register cache (babel#5669)
  Fix operator processing in object super.
  -> parsedAst
  string -> sourceCode, ast -> generatedCode
  back to babylon
  Switch to pirates for babel-register. (babel#3670)
  [skip ci] babylon -> babel, ast -> parsedAst
  [readme] change code -> string
  Add support for object type spread (babel#5525)
  Fix object destructuring in param arrays (babel#5650)
  Remove merge helper and add more type declarations. (babel#5649)
  Typecheck much more of the config loading process (babel#5642)
  update to alpha.9 (babel#5639)
  v7.0.0-alpha.9
  ...
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
* '7.0' of https://github.com/babel/babel: (190 commits)
  Fix incorrect property ordering with obj rest spread on nested (babel#5685)
  Fix PathHoister hoisting before a same-scope variable declaration.
  Updated transform-react-display-name for createReactClass addon (babel#5554)
  Fix PathHoister error attaching after export declarations.
  add .mjs to list of well known extensions
  Remove babel-helper-builder-conditional-assignment-operator-visitor, unused in babel [skip ci] (babel#5676)
  use find-cache-dir for babel-register cache (babel#5669)
  Fix operator processing in object super.
  -> parsedAst
  string -> sourceCode, ast -> generatedCode
  back to babylon
  Switch to pirates for babel-register. (babel#3670)
  [skip ci] babylon -> babel, ast -> parsedAst
  [readme] change code -> string
  Add support for object type spread (babel#5525)
  Fix object destructuring in param arrays (babel#5650)
  Remove merge helper and add more type declarations. (babel#5649)
  Typecheck much more of the config loading process (babel#5642)
  update to alpha.9 (babel#5639)
  v7.0.0-alpha.9
  ...
GulajavaMinistudio added a commit to GulajavaMinistudio/babel that referenced this pull request May 3, 2017
Fix incorrect property ordering with obj rest spread on nested (babel#5685)
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.