Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform do-expressions on exit #5694

Merged
merged 3 commits into from May 19, 2017

Conversation

@jridgewell
Copy link
Member

jridgewell commented May 3, 2017

Q A
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? Yes (block scoping)
Tests Added/Pass? Yes
Fixed Tickets
License MIT
Doc PR
Dependency Changes

This allows other transforms (notably, block scoping) to do their magic
first, possibly saving closures.

Also fixes a bug with declaring duplicate bindings (de-opts into a closure now).

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented May 3, 2017

@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo to be a potential reviewer.

@jridgewell jridgewell changed the base branch from master to 7.0 May 3, 2017
@codecov

This comment has been minimized.

Copy link

codecov bot commented May 3, 2017

Codecov Report

Merging #5694 into 7.0 will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5694      +/-   ##
==========================================
- Coverage   84.61%   84.58%   -0.04%     
==========================================
  Files         283      283              
  Lines        9744     9744              
  Branches     2736     2736              
==========================================
- Hits         8245     8242       -3     
- Misses        986      990       +4     
+ Partials      513      512       -1
Impacted Files Coverage Δ
...babel-plugin-transform-do-expressions/src/index.js 100% <100%> (ø) ⬆️
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%) ⬇️
packages/babel-traverse/src/path/context.js 85.34% <0%> (-1.73%) ⬇️
packages/babel-traverse/src/path/modification.js 73.78% <0%> (-0.98%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.17% <0%> (-0.43%) ⬇️
packages/babel-types/src/converters.js 91.72% <0%> (+0.68%) ⬆️
packages/babel-traverse/src/visitors.js 86.66% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a5377...2121299. Read the comment docs.

@jridgewell jridgewell force-pushed the jridgewell:fix-do-expression-scoping branch from 4aa5790 to abc86d8 May 3, 2017
jridgewell added 2 commits May 3, 2017
This allows other transforms (notably, block scoping) to do their magic
first, possibly saving closures.

Also fixes a bug with declaring duplicate bindings (de-opts now).
@jridgewell jridgewell force-pushed the jridgewell:fix-do-expression-scoping branch from abc86d8 to b81d8f0 May 3, 2017
@hzoo
hzoo approved these changes May 19, 2017
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented May 19, 2017

I wonder if this kind of thing would also be solved with #5735? Curious of your thoughts on that whole issue anyway

I guess we'd need a before/after instead of just "dependencies"

@hzoo hzoo merged commit 8cd4a62 into babel:7.0 May 19, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.58% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.