Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup template-literals transform #5748

Merged
merged 1 commit into from May 19, 2017
Merged

Conversation

@jridgewell
Copy link
Member

jridgewell commented May 19, 2017

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? No
Tests Added/Pass? No
Fixed Tickets
License MIT
Doc PR
Dependency Changes

Avoid Array#shifts and prefer consts when possible.

Avoid `Array#shift`s and prefer `const`s when possible.
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented May 19, 2017

@jridgewell, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo and @existentialism to be potential reviewers.

@codecov

This comment has been minimized.

Copy link

codecov bot commented May 19, 2017

Codecov Report

Merging #5748 into 7.0 will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5748      +/-   ##
==========================================
- Coverage   84.63%   84.58%   -0.06%     
==========================================
  Files         282      282              
  Lines        9861     9854       -7     
  Branches     2766     2766              
==========================================
- Hits         8346     8335      -11     
- Misses        997     1001       +4     
  Partials      518      518
Impacted Files Coverage Δ
...in-transform-es2015-template-literals/src/index.js 100% <100%> (ø) ⬆️
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%) ⬇️
packages/babel-traverse/src/path/modification.js 73.78% <0%> (-0.98%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.12% <0%> (-0.86%) ⬇️
packages/babel-traverse/src/path/context.js 86.2% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce6f672...170eeec. Read the comment docs.

@hzoo
hzoo approved these changes May 19, 2017
Copy link
Member

hzoo left a comment

nice lgtm! 👌

@hzoo hzoo merged commit 09229db into babel:7.0 May 19, 2017
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.58% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.