New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --inspect-brk option to be used with babel-node #5785

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
4 participants
@noinkling
Contributor

noinkling commented May 28, 2017

--inspect-brk was added in Node 7.6 and mentioned in the docs since Node 7.7

Going forward it is preferred over the --inspect --debug-brk combination, which will be deprecated in Node 8 (see nodejs/node#12949)

babel-node should respect this option, currently it just outputs:
error: unknown option `--inspect-brk'

Note: I wasn't quite sure which branch to make the pull request for, so I just used the default (7.0), but it would be nice to get it into 6.x as well.

@mention-bot

This comment has been minimized.

mention-bot commented May 28, 2017

@noinkling, thanks for your PR! By analyzing the history of the files in this pull request, we identified @neVERberleRfellerER, @danez and @hzoo to be potential reviewers.

@codecov

This comment has been minimized.

codecov bot commented May 28, 2017

Codecov Report

Merging #5785 into 7.0 will increase coverage by 0.05%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5785      +/-   ##
==========================================
+ Coverage   84.75%   84.81%   +0.05%     
==========================================
  Files         282      282              
  Lines        9874     9875       +1     
  Branches     2776     2777       +1     
==========================================
+ Hits         8369     8375       +6     
+ Misses        996      991       -5     
  Partials      509      509
Impacted Files Coverage Δ
packages/babel-cli/src/babel-node.js 46.8% <0%> (-1.02%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.98% <0%> (+0.85%) ⬆️
packages/babel-traverse/src/path/modification.js 73.07% <0%> (+0.96%) ⬆️
packages/babel-traverse/src/path/context.js 86.2% <0%> (+1.72%) ⬆️
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2579c5b...517ecda. Read the comment docs.

@hzoo

hzoo approved these changes May 30, 2017 edited

lgtm probably want to land something like #5398 too

Thanks for the PR! (didn't know about this new option)

@jridgewell jridgewell merged commit d34d2b1 into babel:7.0 May 30, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.81% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@noinkling

This comment has been minimized.

Contributor

noinkling commented May 31, 2017

Should I open a PR for 6.x as well?

@jridgewell

This comment has been minimized.

Member

jridgewell commented May 31, 2017

Please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment