New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow opaque type aliases #5990

Merged
merged 21 commits into from Aug 2, 2017

Conversation

Projects
None yet
4 participants
@jbrown215
Contributor

jbrown215 commented Jul 21, 2017

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? Yes
Deprecations? No
Spec Compliancy? Yes
Tests Added/Pass? Yes
Fixed Tickets None
License MIT
Doc PR ?
Dependency Changes N/A

Adds support for Flow's opaque type aliases. Babylon support was added in this PR: babel/babylon#643

Tests pass when using the current state of babylon's master branch. Backport for 6.x will come after this lands.

I tried to split my commits in a way that would make it easier to review. The first two are the only code changes I made, the rest are tests.

Q: I assume I probably should update the babel-types README to include declareOpaqueType and opaqueType, but I noticed all of the docs refer to to.is__ and t.assert__ which only look like they are declared in an autogenerated file. Should I run that script myself?

@danez

danez approved these changes Jul 24, 2017

@samwgoldman

This comment has been minimized.

Contributor

samwgoldman commented Jul 24, 2017

👍

Flow 0.51 is released with Flow-side support for opaque types. Excited for this to land!

@existentialism

This comment has been minimized.

Member

existentialism commented Jul 25, 2017

@jbrown215 yep, run that script!

jbrown215 and others added some commits Jul 25, 2017

@jbrown215

This comment has been minimized.

Contributor

jbrown215 commented Jul 25, 2017

@existentialism Ran generate-interfaces and generate-babel-types-docs! :D

excited!

@jbrown215

This comment has been minimized.

Contributor

jbrown215 commented Jul 25, 2017

@existentialism should I not have run one of those scripts? travis build failed from one of the files changed by the script

@existentialism

This comment has been minimized.

Member

existentialism commented Aug 1, 2017

@jbrown215 just fyi, I pushed #6031 to fix the CI error! :)

@jbrown215

This comment has been minimized.

Contributor

jbrown215 commented Aug 1, 2017

@existentialism thanks for the help! looks like tests are passing now :D

@existentialism existentialism merged commit 4e9a25e into babel:7.0 Aug 2, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.39% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment