New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to pass array of deps to a helper #6058

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@peey
Contributor

peey commented Aug 6, 2017

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? Yes
Deprecations? No
Spec Compliancy? Yes
Tests Added/Pass? No
Fixed Tickets Closes #6030
License MIT
Doc PR No
Dependency Changes No

Hi, this is a simple way to allow for interdependent helpers (see #6030 for explanation). I could not wait on #5706 since the upcoming decorator transform uses this feature, and neither could I hack on 5706 myself.

I couldn't figure a way to add tests for this (since you'd have to introduce new helpers in helpers.js just for the sake of this PR) but I've added some new helpers in a wip branch and it works with those.

I suppose this could be repealed after we have an ability to simply import helpers when 5706 makes them modular.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 6, 2017

@peey, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @hzoo and @existentialism to be potential reviewers.

mention-bot commented Aug 6, 2017

@peey, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @hzoo and @existentialism to be potential reviewers.

@hzoo hzoo requested a review from loganfsmyth Aug 10, 2017

@peey peey referenced this pull request Aug 15, 2017

Closed

Decorators 2 Transform [WIP] #6107

@danez danez closed this Aug 31, 2017

@danez danez reopened this Aug 31, 2017

@danez danez changed the base branch from 7.0 to master Aug 31, 2017

@jridgewell

This comment has been minimized.

Show comment
Hide comment
@jridgewell

jridgewell Sep 15, 2017

Member

Can you update this post #5706? We could support it using import helper from "helper-name" now.

Member

jridgewell commented Sep 15, 2017

Can you update this post #5706? We could support it using import helper from "helper-name" now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment