New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split export extensions into 2 #6080

Merged
merged 3 commits into from Aug 19, 2017

Conversation

Projects
None yet
5 participants
@echo304
Contributor

echo304 commented Aug 9, 2017

Q A
Patch: Bug Fix? no
Major: Breaking Change? yes
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? no
Fixed Tickets Fixes #6075
License MIT
Doc PR
Dependency Changes

#6075
Split babel-plugin-transform-export-extensions into two while keeping babel-plugin-syntax-export-extensions

  • babel-plugin-transform-export-default
  • babel-plugin-transform-export-namespace

@echo304 echo304 changed the title from [WIP] split export extensions into 2 to Split export extensions into 2 Aug 10, 2017

@hzoo

This comment has been minimized.

Member

hzoo commented Aug 10, 2017

while keeping babel-plugin-syntax-export-extensions

Actually thats a good point, we may want to figure that out too (in a later pr/change) - should be split?

@hzoo

This comment has been minimized.

Member

hzoo commented Aug 10, 2017

Sorry will need to do a rebase/fix conflicts since we modified class properties in #6076

@echo304

This comment has been minimized.

Contributor

echo304 commented Aug 11, 2017

rebased and fixed conflicts!

@xtuc

xtuc approved these changes Aug 11, 2017

Thanks @echo304 👍

This is a breaking for people relying directly on the old plugin.

> Compile additional export-from statements to ES2015
> Compile additional export-default-from statements to ES2015

This comment has been minimized.

@existentialism

existentialism Aug 11, 2017

Member

Nit: can probably drop the "additional" bit?

@@ -11,6 +11,7 @@
"babel-plugin-transform-class-properties": "7.0.0-alpha.19",
"babel-plugin-transform-function-sent": "7.0.0-alpha.19",
"babel-plugin-transform-numeric-separator": "7.0.0-alpha.19",
"babel-plugin-transform-export-namespace": "7.0.0-alpha.19",

This comment has been minimized.

@existentialism

existentialism Aug 11, 2017

Member

Nit: alpha sort this

@existentialism

Two super small nits, but 👍

@hzoo

This comment has been minimized.

Member

hzoo commented Aug 12, 2017

If you want we could make the old name use the 2 new plugins and deprecate it to say you should use the new one but dono if we want to do that (that only is a thing if they are using the actual name vs the preset)

@echo304

This comment has been minimized.

Contributor

echo304 commented Aug 12, 2017

@hzoo Let me clarify a little bit. So what you've suggested is that we'd better remain old plugin named babal-plugin-transform-export-extensions which refer to 2 new plugins(export-namespace and export-default) to support backward compatibility. Am I right?

@hzoo hzoo referenced this pull request Aug 15, 2017

Merged

Create aug-16.md #32

@hzoo hzoo requested review from jdalton and benjamn Aug 16, 2017

@hzoo hzoo merged commit c6a094a into babel:7.0 Aug 19, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.14% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hzoo

This comment has been minimized.

Member

hzoo commented Aug 19, 2017

Thanks @echo304, this is great!

Yeah I was thinking we the old plugin would just include both but we would deprecate it (we don't have to do this). Or we just make the new plugin error and say you have to include either of the new plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment