Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the deprecated jsx pragma detection code #6145

Merged
merged 3 commits into from Aug 22, 2017

Conversation

@asthas
Copy link
Contributor

asthas commented Aug 22, 2017

Q A
Fixed Issues Fixes #6141
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added/Pass? N/A / Yes
Spec Compliancy? N/A
License MIT
Doc PR No
Any Dependency Changes?
  • Removed deprecated JSX pragma (React v16 already throws an error about this being deprecated so dropped it from Babel 7).
  • Also removed the concerned tests for jsx pragma.
…sts that included jsx-pragma
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Aug 22, 2017

@asthas, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ArrestedDevelopment, @chicoxyzzy and @existentialism to be potential reviewers.

@asthas asthas changed the title Removed the deprecated jsx pragma detection code and the concerned te… Removed the deprecated jsx pragma detection code Aug 22, 2017
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Aug 22, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4681/

@@ -1,6 +0,0 @@
<Foo></Foo>;

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Aug 22, 2017

Member

We should keep this test, since it doesn't test the @jsx pragma but the "pragma" option

This comment has been minimized.

Copy link
@asthas

asthas Aug 22, 2017

Author Contributor

@nicolo-ribaudo Thanks for pointing out! :) Restored it.

…t/honor-custom-jsx-pragma-option/
@hzoo
hzoo approved these changes Aug 22, 2017
Copy link
Member

hzoo left a comment

nice work!

Also tested this behavior in the repl link and the current repl

@hzoo hzoo merged commit 62c22c7 into babel:7.0 Aug 22, 2017
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.1% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@asthas asthas mentioned this pull request Sep 2, 2017
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.