Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make babel-register 7.x backward-compatible with 6.x. #6268

Merged
merged 1 commit into from Sep 19, 2017

Conversation

@loganfsmyth
Copy link
Member

loganfsmyth commented Sep 18, 2017

Q                       A
Fixed Issues Fixes #6266
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added/Pass?
Spec Compliancy?
License MIT
Doc PR
Any Dependency Changes?
export default function() {}
export default function register() {}

export function revert() {}

This comment has been minimized.

Copy link
@hzoo

hzoo Sep 18, 2017

Member

do we need this?

This comment has been minimized.

Copy link
@loganfsmyth

loganfsmyth Sep 18, 2017

Author Member

Yeah otherwise the interfaces aren't consistent. browser.js is swapped for node.js in browser builds, so they should both export the same interface. Seems like just an oversight.

I have no idea if anyone is using that build, I can't imagine they are, but you never know :)

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Sep 18, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4971/

@loganfsmyth loganfsmyth merged commit bd734f0 into babel:master Sep 19, 2017
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.36% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:register-compat-fixes branch Sep 19, 2017
*/

exports = module.exports = function(...args) {
return register(...args);

This comment has been minimized.

Copy link
@Jessidhia

Jessidhia Sep 20, 2017

Member

This doesn't forward the this but it's probably irrelevant 🤷‍♀️

@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.