Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only transform 'this'->'undefined' and inject 'use strict' if module statements are present #6280

Merged
merged 5 commits into from Sep 23, 2017

Conversation

Projects
None yet
4 participants
@loganfsmyth
Copy link
Member

commented Sep 20, 2017

Q                       A
Fixed Issues
Patch: Bug Fix? N
Major: Breaking Change? Y
Minor: New Feature?
Tests Added/Pass?
Spec Compliancy?
License MIT
Doc PR
Any Dependency Changes?

This is a step toward #6242 that I think we can all agree on no matter what. This brings Babel more in line with "unambiguous" behavior, which ideally will change to just checking sourceType pending the issue above.

This at least makes it so we don't 100% break CommonJS modules if Babel is run on them.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Sep 20, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4994/

@loganfsmyth loganfsmyth merged commit b115ea5 into babel:master Sep 23, 2017

4 checks passed

babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.42% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@loganfsmyth loganfsmyth deleted the loganfsmyth:only-transform-modules branch Sep 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.