Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug closures #6349

Merged
merged 1 commit into from Sep 30, 2017

Conversation

@jridgewell
Copy link
Member

jridgewell commented Sep 30, 2017

God, can you imagine how many useless closures this was creating?

God, can you imagine how many useless closures this was creating?
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Sep 30, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5101/

1 similar comment
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Sep 30, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5101/

Copy link
Member

loganfsmyth left a comment

Seems fine to me. It's almost entirely static strings or infrequently-called cases anyway.

@jridgewell jridgewell merged commit 0e432f0 into babel:master Sep 30, 2017
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.83% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jridgewell jridgewell deleted the jridgewell:remove-debug-closures branch Sep 30, 2017
@jridgewell jridgewell restored the jridgewell:remove-debug-closures branch Apr 9, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.