Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destructuring in pipeline operator #6515

Merged
merged 2 commits into from Oct 19, 2017
Merged

Conversation

@jridgewell
Copy link
Member

jridgewell commented Oct 19, 2017

Fixes #6514.

@hzoo
hzoo approved these changes Oct 19, 2017
Copy link
Member

hzoo left a comment

nice, should be the same for others? thinking of other things as params

spread: [0,1,2] |> (...x) => x;
default param (what does that even mean in that case lol)?

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Oct 19, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5422/

@jridgewell

This comment has been minimized.

Copy link
Member Author

jridgewell commented Oct 19, 2017

Yah, we only optimize away param-less and single identifier. Everything else can be slow path for now.

@jridgewell jridgewell force-pushed the jridgewell:pipeline2 branch from 1700a91 to 1b35db5 Oct 19, 2017
@jridgewell jridgewell merged commit 8d4674c into babel:master Oct 19, 2017
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.95% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jridgewell jridgewell deleted the jridgewell:pipeline2 branch Oct 19, 2017
@jridgewell jridgewell restored the jridgewell:pipeline2 branch Apr 9, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.