Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for flow bindings #6528

Merged
merged 1 commit into from Nov 9, 2017

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Oct 21, 2017

Q                       A
Fixed Issues? #5395
Patch: Bug Fix?
Major: Breaking Change? 👍
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?

Flow bindings have been deprecated for a while.
The reason behind this change is that declare var foo
doesn't introduce a new local binding, but it represents
a global one.

Flow bindings have been deprecated for a while.
The reason behind this change is that `declare var foo`
doesn't introduce a new local binding, but it represents
a global one.
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Oct 21, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/5443/

@danez
danez approved these changes Nov 5, 2017
@loganfsmyth loganfsmyth merged commit 9a231c5 into babel:master Nov 9, 2017
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 86.96% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:remove-flow-bindings branch Nov 9, 2017
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.