Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some reserved type handling and declare class with multiple extends #6725



Copy link

existentialism commented Nov 1, 2017

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? sorta?
Minor: New Feature? n
Tests Added + Pass? y/y
Documentation PR
Any Dependency Changes?
License MIT

Matches some additional parser updates in flow@0.58:

declare class with multiple extends is a parse error

[parser] reserved types in import-typeof declarations should error

[parser] forbid reserved types in opaque type

[parser] interfaces should error on reserved types instead of reserved values

/cc: @babel/flow


This comment has been minimized.

Copy link

babel-bot commented Nov 1, 2017

Build successful! You can test your changes in the REPL here:

@existentialism existentialism merged commit 0f2ab2f into babel:master Nov 15, 2017
4 checks passed
4 checks passed
babel/repl REPL preview is available
ci/circleci Your tests passed on CircleCI!
codecov/project 87.01% (target 80%)
continuous-integration/travis-ci/pr The Travis CI build passed
@existentialism existentialism deleted the existentialism:typeof_named_reserved_type branch Nov 15, 2017
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
4 participants
You can’t perform that action at this time.