Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate better builder names for JSX* and TS* #6967

Merged

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Dec 4, 2017

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR
Any Dependency Changes?
License MIT

t.jsxIdentifier() is much nicer and intuitive than t.jSXIdentifier().
I also kept the old function names, so this pr doesn't introduce breaking changes.

e.g. JSXIdentifier -> jsxIdentifier.
The jSXIdentifier alias isn't removed, so this commit doesn't introduce breaking changes.
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Dec 4, 2017

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6092/

@existentialism

This comment has been minimized.

Copy link
Member

existentialism commented Dec 4, 2017

Yessssss :)

@xtuc

This comment has been minimized.

Copy link
Member

xtuc commented Dec 5, 2017

Thanks for your PR, i'm 👍 on this but also a bit 👎 since it will introduce another alternative way of doing the same thing.

But I understand we need to preserve the current API.

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Dec 5, 2017

We could remove jSX*before the final Babel 7 release, but I prefer having two ways of doing the same thing instead of an unnecessary breaking change.

@hzoo
hzoo approved these changes Dec 6, 2017
Copy link
Member

hzoo left a comment

Yep I would just do what @nicolo-ribaudo suggested and remove the bc code in the final release (add a TODO issue explaining this)

@xtuc
xtuc approved these changes Dec 7, 2017
Copy link
Member

xtuc left a comment

@nicolo-ribaudo nicolo-ribaudo merged commit a2aabbd into babel:master Dec 7, 2017
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 81.07% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:babel-types-lowercase-builders branch Dec 7, 2017
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.