Remove check-constants plugin

[maurobringolf]

Q	A
Fixed Issues?	Fixes #5967
Patch: Bug Fix?	no
Major: Breaking Change?	no
Minor: New Feature?	no
Tests Added + Pass?	Yes
Documentation PR
Any Dependency Changes?
License	MIT

This is a recreation of #6661 including the recent changes to check-constants.

As discussed in the issue, I moved the code from check-constants into block-scoping including the tests. I also removed all references to the plugin I could find.

I had to pass state into the BlockScoping class to access addHelper. I am not sure if this is the best way to do it, but it seems to work so far.

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6692/

[nicolo-ribaudo]

Can you put the new code in a checkConstants method instead of updateScopeInfo?

[maurobringolf]

@nicolo-ribaudo Sorry for the delay. I'd still like to remove the check-constants plugin so I rebased the PR. The CI passed (98fa9ab) but after I moved the constants check into a separate method it failed due to timeout. Locally it passes.

Any ideas? Does this way trigger redundant constant check runs through scopes and make things slower than before? I thought the DONE set prevents that.

[existentialism]

@maurobringolf unlikely related to your PR/changes, restarted the build on circle

[maurobringolf]

Ahh nice, thank you! I didnt ask because the last time I did, it actually was an error in my code 😁 .

[hzoo]

next pr: we should maybe include parts of this readme into the blocking scoping one?

[maurobringolf]

Good point, I can do this later tonight (today for you 😁)

[maurobringolf]

@hzoo I just added a note for the constants check in the readme #7279. Improvements to wording welcome! Anything else that is needed from a documentation perspective?