Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use helper-module-import inside preset-env #7562

Merged
merged 2 commits into from Mar 15, 2018
Merged

Use helper-module-import inside preset-env #7562

merged 2 commits into from Mar 15, 2018

Conversation

@existentialism
Copy link
Member

existentialism commented Mar 14, 2018

Q                       A
Fixed Issues? Fixes #6601, Fixes #7457, Closes #7534, Closes #7468
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? y/y
Documentation PR
Any Dependency Changes?
License MIT

Tweaked #7534 a bit and updated the entry plugin to use the helper as well.

Thanks to @Swatto and @debugpai2 for all the help!

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Mar 14, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7264/

Swatto and others added 2 commits Mar 9, 2018
@hzoo
hzoo approved these changes Mar 15, 2018
Copy link
Member

hzoo left a comment

seems good!

@hzoo hzoo merged commit ae210a4 into master Mar 15, 2018
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.63% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Jessidhia Jessidhia deleted the pr/7534 branch Mar 16, 2018
This was referenced Mar 16, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.