Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for ES2018 in preset-env #7658

Merged
merged 1 commit into from Apr 17, 2018

Conversation

@existentialism
Copy link
Member

existentialism commented Apr 3, 2018

Q                       A
Fixed Issues? Fixes #7430
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? y
Tests Added + Pass? y/y
Documentation PR
Any Dependency Changes?
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 3, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7428/

@existentialism existentialism removed the PR: WIP label Apr 3, 2018
@existentialism existentialism requested a review from hzoo Apr 10, 2018
@hzoo
hzoo approved these changes Apr 12, 2018
Copy link
Member

hzoo left a comment

nice

@guidobouman

This comment has been minimized.

Copy link

guidobouman commented Apr 12, 2018

Oooh! When is this releasing? 😱

@existentialism existentialism merged commit 81149a5 into master Apr 17, 2018
5 checks passed
5 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.55% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@existentialism existentialism deleted the env-es2018 branch Apr 17, 2018
@billyjanitsch

This comment has been minimized.

Copy link

billyjanitsch commented Apr 23, 2018

How would one pass the equivalent of {useBuiltIns: true} to plugin-proposal-object-rest-spread through preset-env? The useBuiltIns option of preset-env has no effect.

@cmswalker

This comment has been minimized.

Copy link

cmswalker commented Apr 25, 2018

Thanks for that clarification

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants
You can’t perform that action at this time.