Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix super in class fields. #7659

Merged

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Apr 3, 2018

Q                       A
Fixed Issues? Fixes #7574, fixes #6913
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Never extract class fields into an initializer function

It was needed to avoid collision of identifiers used in fields
initializers with variables declared in the constructor, but it
broke this handling.
This commit removes that behavior and instead renames the
colliding variables.

It was needed to avoid collision of identifiers used in fields
initializers with variables declared in the constructor, but it
broke `this` handling.
This commit removes that behavior and instead renames the
colliding variables.
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 3, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7432/

@xtuc
xtuc approved these changes Apr 5, 2018
@jridgewell jridgewell merged commit fa2c6c5 into babel:master Apr 5, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 84.54% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:class-props-collision-rename branch Apr 5, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.