Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: Ignore lerna.json and .git #7708

Merged
merged 2 commits into from Apr 10, 2018
Merged

Conversation

@jridgewell
Copy link
Member

jridgewell commented Apr 10, 2018

No description provided.

@xtuc
xtuc approved these changes Apr 10, 2018
Copy link
Member

xtuc left a comment

thanks 🚀

@@ -1,6 +1,8 @@
/lib
/build
/.git

This comment has been minimized.

Copy link
@xtuc

xtuc Apr 10, 2018

Member

that should be by default tho

This comment has been minimized.

Copy link
@jridgewell

jridgewell Apr 10, 2018

Author Member

I just created a ignore-lerna.json branch, it it linted my git internals.

# The config is hardcoded because otherwise prettier searches for it and also picks up some broken package.json files from tests
./node_modules/.bin/prettier --config .prettierrc --write --ignore-path .eslintignore '**/*.json'
.eslintrc.json 65ms
.git/logs/refs/heads/ignore-lerna.json
[error] .git/logs/refs/heads/ignore-lerna.json: SyntaxError: Invalid number (1:1)
[error] > 1 | 0000000000000000000000000000000000000000 bd98041321c60737ddcacd1ad7e056ef6de31879 Justin Ridgewell 1523363440 -0400	branch: Created from HEAD
[error]     | ^
[error]   2 | bd98041321c60737ddcacd1ad7e056ef6de31879 6d22432ae0ff31ca5d08311b0065bb40cee25920 Justin Ridgewell 1523363441 -0400	commit: Ignore lerna.json
[error]   3 |
.git/refs/heads/ignore-lerna.json
[error] .git/refs/heads/ignore-lerna.json: SyntaxError: Identifier directly after number (1:2)
[error] > 1 | 6d22432ae0ff31ca5d08311b0065bb40cee25920
[error]     |  ^
[error]   2 |
packages/babel-plugin-transform-runtime/src/options.json 3ms
make: *** [fix] Error 2
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 10, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7537/

@jridgewell jridgewell merged commit 3177f05 into babel:master Apr 10, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.75% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jridgewell jridgewell deleted the jridgewell:ignore-lerna.json branch Apr 10, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.