New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Node.js v4 #7755

Merged
merged 2 commits into from Apr 21, 2018

Conversation

Projects
None yet
8 participants
@boneskull
Contributor

boneskull commented Apr 18, 2018

Q                       A
Fixed Issues? Fixes #7753
Patch: Bug Fix? n/a
Major: Breaking Change? Yes
Minor: New Feature? n/a
Tests Added + Pass? Yes
Documentation PR n/a
Any Dependency Changes? n/a
License MIT
  • remove version 4 from Travis build matrix
  • update environment support doc
  • update CONTRIBUTING.md
  • update engines field of root package.json

If I need to make changes elsewhere, please let me know. I didn't see that the engines field was present (nor getting copied) into packages' package.json; maybe it should be.

(I'll also look to see if the website needs a PR for this.)

drop support for Node.js v4; closes #7753
- remove version 4 from Travis build matrix
- update environment support doc
- update `CONTRIBUTING.md`
- update `engines` field of root `package.json`

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull

This comment has been minimized.

Show comment
Hide comment
@boneskull

boneskull Apr 18, 2018

Contributor

I don't see the minimum Node.js version mentioned anywhere on the site; not sure where exactly that information should live. Any suggestions?

Contributor

boneskull commented Apr 18, 2018

I don't see the minimum Node.js version mentioned anywhere on the site; not sure where exactly that information should live. Any suggestions?

@babel-bot

This comment has been minimized.

Show comment
Hide comment
@babel-bot

babel-bot Apr 18, 2018

Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7638/

Collaborator

babel-bot commented Apr 18, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7638/

@anajavi

This comment has been minimized.

Show comment
Hide comment
@anajavi

anajavi commented Apr 19, 2018

@xtuc

This comment has been minimized.

Show comment
Hide comment
@xtuc
Member

xtuc commented Apr 19, 2018

@xtuc

xtuc approved these changes Apr 19, 2018

LGTM, so Babel 7 drops Node 0.10, 0.12 and 4.

update engines for babylon
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@nicolo-ribaudo

This comment has been minimized.

Show comment
Hide comment
@nicolo-ribaudo

nicolo-ribaudo Apr 19, 2018

Member

There are some tests which use "minNodeVersion": "6.0.0". That option can be removed if we don't run tests on Node 4 anymore.

Member

nicolo-ribaudo commented Apr 19, 2018

There are some tests which use "minNodeVersion": "6.0.0". That option can be removed if we don't run tests on Node 4 anymore.

@jridgewell

This comment has been minimized.

Show comment
Hide comment
@jridgewell

jridgewell Apr 20, 2018

Member

That option can be removed if we don't run tests on Node 4 anymore.

Let's do that as a follow up?

Member

jridgewell commented Apr 20, 2018

That option can be removed if we don't run tests on Node 4 anymore.

Let's do that as a follow up?

@danez

This comment has been minimized.

Show comment
Hide comment
@danez

danez Apr 20, 2018

Member

I would have thought we should also change the node-version for preset-env in our own babelrc file, but as it turns out we are not even setting it. So we always apply all transforms for publish-builds. Is that on purpose?

Member

danez commented Apr 20, 2018

I would have thought we should also change the node-version for preset-env in our own babelrc file, but as it turns out we are not even setting it. So we always apply all transforms for publish-builds. Is that on purpose?

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Apr 20, 2018

Member

Yeah it was, it didn't seem any faster at the time and it was for babel-standalone but that is compiled separately now (and needs transform-runtime or polyfill). We can probably just target 6 though.

Member

hzoo commented Apr 20, 2018

Yeah it was, it didn't seem any faster at the time and it was for babel-standalone but that is compiled separately now (and needs transform-runtime or polyfill). We can probably just target 6 though.

@boneskull

This comment has been minimized.

Show comment
Hide comment
@boneskull

boneskull Apr 21, 2018

Contributor

Is there anything actionable here for me to do?

Contributor

boneskull commented Apr 21, 2018

Is there anything actionable here for me to do?

@jridgewell jridgewell merged commit b0e1e84 into babel:master Apr 21, 2018

4 checks passed

babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.88% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jridgewell

This comment has been minimized.

Show comment
Hide comment
@jridgewell

jridgewell Apr 21, 2018

Member

Good enough for now.

If want to do a bit more, we can now remove every minNodeVersion that's <= to 6 in the code base, since that's now the default minimum version.

Member

jridgewell commented Apr 21, 2018

Good enough for now.

If want to do a bit more, we can now remove every minNodeVersion that's <= to 6 in the code base, since that's now the default minimum version.

@boneskull

This comment has been minimized.

Show comment
Hide comment
@boneskull

boneskull Apr 21, 2018

Contributor

GUESS NOT

Contributor

boneskull commented Apr 21, 2018

GUESS NOT

@boneskull boneskull deleted the boneskull:drop-node-v4 branch Apr 21, 2018

@hzoo hzoo referenced this pull request Apr 23, 2018

Merged

Target Node 6 in production #7782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment