Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop support for Node.js v4 #7755

Merged
merged 2 commits into from Apr 21, 2018
Merged

drop support for Node.js v4 #7755

merged 2 commits into from Apr 21, 2018

Conversation

@boneskull
Copy link
Contributor

@boneskull boneskull commented Apr 18, 2018

Q                       A
Fixed Issues? Fixes #7753
Patch: Bug Fix? n/a
Major: Breaking Change? Yes
Minor: New Feature? n/a
Tests Added + Pass? Yes
Documentation PR n/a
Any Dependency Changes? n/a
License MIT
  • remove version 4 from Travis build matrix
  • update environment support doc
  • update CONTRIBUTING.md
  • update engines field of root package.json

If I need to make changes elsewhere, please let me know. I didn't see that the engines field was present (nor getting copied) into packages' package.json; maybe it should be.

(I'll also look to see if the website needs a PR for this.)

- remove version 4 from Travis build matrix
- update environment support doc
- update `CONTRIBUTING.md`
- update `engines` field of root `package.json`

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@boneskull boneskull force-pushed the boneskull:drop-node-v4 branch from 87a057f to 5bd5cd1 Apr 18, 2018
@boneskull
Copy link
Contributor Author

@boneskull boneskull commented Apr 18, 2018

I don't see the minimum Node.js version mentioned anywhere on the site; not sure where exactly that information should live. Any suggestions?

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Apr 18, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7638/

@anajavi
Copy link

@anajavi anajavi commented Apr 19, 2018

@xtuc
Copy link
Member

@xtuc xtuc commented Apr 19, 2018

@xtuc
xtuc approved these changes Apr 19, 2018
Copy link
Member

@xtuc xtuc left a comment

LGTM, so Babel 7 drops Node 0.10, 0.12 and 4.

Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 19, 2018

There are some tests which use "minNodeVersion": "6.0.0". That option can be removed if we don't run tests on Node 4 anymore.

@jridgewell
Copy link
Member

@jridgewell jridgewell commented Apr 20, 2018

That option can be removed if we don't run tests on Node 4 anymore.

Let's do that as a follow up?

@danez
Copy link
Member

@danez danez commented Apr 20, 2018

I would have thought we should also change the node-version for preset-env in our own babelrc file, but as it turns out we are not even setting it. So we always apply all transforms for publish-builds. Is that on purpose?

@hzoo
Copy link
Member

@hzoo hzoo commented Apr 20, 2018

Yeah it was, it didn't seem any faster at the time and it was for babel-standalone but that is compiled separately now (and needs transform-runtime or polyfill). We can probably just target 6 though.

@boneskull
Copy link
Contributor Author

@boneskull boneskull commented Apr 21, 2018

Is there anything actionable here for me to do?

@jridgewell jridgewell merged commit b0e1e84 into babel:master Apr 21, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.88% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jridgewell
Copy link
Member

@jridgewell jridgewell commented Apr 21, 2018

Good enough for now.

If want to do a bit more, we can now remove every minNodeVersion that's <= to 6 in the code base, since that's now the default minimum version.

@boneskull
Copy link
Contributor Author

@boneskull boneskull commented Apr 21, 2018

GUESS NOT

@boneskull boneskull deleted the boneskull:drop-node-v4 branch Apr 21, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

8 participants
You can’t perform that action at this time.