Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Object Spread Syntax #7777

Merged
merged 2 commits into from Apr 24, 2018

Conversation

@jridgewell
Copy link
Member

jridgewell commented Apr 22, 2018

No description provided.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 22, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7703/

Copy link
Member

nicolo-ribaudo left a comment

Cool!

@hzoo

This comment has been minimized.

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Apr 23, 2018

Also is it reasonable that we would use loose mode and useBuiltIns then in the Babel config?

import syntaxObjectRestSpread from "@babel/plugin-syntax-object-rest-spread";
import { types as t } from "@babel/core";

export default function() {

This comment has been minimized.

Copy link
@existentialism

existentialism Apr 23, 2018

Member

Nit: can avoid importing types from core, with:

export default function({ types: t })
Copy link
Member

existentialism left a comment

LGTM, just one small nit

@xtuc
xtuc approved these changes Apr 23, 2018
Copy link
Member

xtuc left a comment

Cool!

@jridgewell jridgewell merged commit 2afe940 into babel:master Apr 24, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.82% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jridgewell jridgewell deleted the jridgewell:object-assign-to-object-spread branch Apr 24, 2018
@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.