Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on node 10 #7908

Merged
merged 4 commits into from Jun 4, 2018
Merged

Test on node 10 #7908

merged 4 commits into from Jun 4, 2018

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented May 11, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented May 12, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8281/

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented May 13, 2018

Depends on gulpjs/v8flags#50

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:node-10 branch from c97b7b0 to a693b05 Jun 4, 2018
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:node-10 branch from a693b05 to b2c5509 Jun 4, 2018
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Jun 4, 2018

It's finally working 🎉 😆

@xtuc
xtuc approved these changes Jun 4, 2018
@nicolo-ribaudo nicolo-ribaudo merged commit f838a7e into babel:master Jun 4, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.57% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:node-10 branch Jun 4, 2018
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Jun 7, 2018
* Use node 10 on circle an node 9 on travis

* Update v8flag
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.