Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passes the jsxPragma options from preset-typescript to plugin-transform-typescript #7990

Merged
merged 3 commits into from May 21, 2018

Conversation

@malbernaz
Copy link
Contributor

malbernaz commented May 21, 2018

Q                       A
Fixed Issues? Fixes #7989, Fixes #7979
Patch: Bug Fix? yes
Tests Added + Pass? yes
Any Dependency Changes? no
License MIT

Jsx pragmas were being ignored by preset-typescript. I've simply passed the jsxPragma option to the plugin-transform-typescript.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented May 21, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8082/

@@ -1,10 +1,10 @@
import { declare } from "@babel/helper-plugin-utils";
import transformTypeScript from "@babel/plugin-transform-typescript";

export default declare(api => {
export default declare((api, { jsxPragma = "React" }) => {

This comment has been minimized.

Copy link
@loganfsmyth

loganfsmyth May 21, 2018

Member

This default is already set for the transform itself, so it would better not to repeat it again.

@hzoo
hzoo approved these changes May 21, 2018
@xtuc
xtuc approved these changes May 21, 2018
@hzoo hzoo merged commit bc757c8 into babel:master May 21, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.8% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented May 21, 2018

Awesome nice work @malbernaz! Both for the issue and PR!!

@malbernaz

This comment has been minimized.

Copy link
Contributor Author

malbernaz commented May 21, 2018

Yo! Thanks! Loved to help

@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.