Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a promise-returning *Async version of the transform and parse fns #8023
Conversation
This comment has been minimized.
This comment has been minimized.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8161/ |
|
|
||
| // For backward-compat with Babel 7's early betas, we allow sync parsing when | ||
| // no callback is given. Will be dropped in some future Babel major version. | ||
| if (callback === undefined) return parseSync(code, opts); |
This comment has been minimized.
This comment has been minimized.
nicolo-ribaudo
May 24, 2018
Member
Q: If we wanted to introduce a warning, would it be a breaking change? Or we could do it in a minor/patch version?
This comment has been minimized.
This comment has been minimized.
loganfsmyth
May 24, 2018
Author
Member
I mostly added this to make lives easier for people, I actually thought about removing it in this PR, but since it's so trivial leaving it to 8.x isn't really that much of a problem.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
loganfsmyth commentedMay 24, 2018
We've already got
transformFileandtransformFileSyncfor instance, so this addstransformFileAsyncas a promise-returing version.