Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Labels to READMEs Generator & Update README's w. Links To Open Issues (for some pkg's) #8144

Merged
merged 3 commits into from Jun 11, 2018

Conversation

@BeniCheni
Copy link
Contributor

BeniCheni commented Jun 11, 2018

Q                       A
Fixed Issues? Fixes #8118
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR [skip ci]
Any Dependency Changes?
License MIT

After analyzing #8118, (related #8131 & #8133), this PR attempts to map out the labels variable for reeadme.jsdoc generator to map out the README.md files and the links of open issues with correct labels, for the following packages in the /packages directory:

  • @babel/generator => pkg: generator label
  • @babel/template => pkg: template label
  • @babel/standalone => pkg: standalone label
  • @babel/node => area: node: label
… & update READMES w. links for open issues

babel-generator; babel-node; babel-standalone; babel-template
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jun 11, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8348/

babel-generator; babel-node; babel-standalone; babel-template
"babel-preset-react": getIssueLabelLink("area: react"),
"babel-preset-typescript": getIssueLabelLink("area: typescript"),

This comment has been minimized.

Copy link
@BeniCheni

BeniCheni Jun 11, 2018

Author Contributor

☝️ simple note: babel-preset-typescript is moved here to try to sort area labels alphabetically.

@xtuc
xtuc approved these changes Jun 11, 2018
Copy link
Member

xtuc left a comment

Thanks

@xtuc xtuc merged commit 5bd79c7 into babel:master Jun 11, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.56% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@BeniCheni BeniCheni deleted the BeniCheni:add-labels-to-readmes branch Jun 11, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.