Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove emojis from cli output #8250

Merged
merged 1 commit into from Jul 2, 2018
Merged

Conversation

@johnbuffington
Copy link
Contributor

johnbuffington commented Jul 2, 2018

Q                       A
Fixed Issues? Fixes #8243
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? yes
Tests Added + Pass? Yes
Documentation PR no
Any Dependency Changes? no
License MIT

These changes fix display issues on some terminals caused by the use of emojis in output. emojis have been removed from cli package as well as preset-env package

@johnbuffington johnbuffington changed the title remove emojis from cli output (#8243) remove emojis from cli output Jul 2, 2018
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jul 2, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8472/

@xtuc
xtuc approved these changes Jul 2, 2018
Copy link
Member

xtuc left a comment

thanks

@nicolo-ribaudo nicolo-ribaudo merged commit 236bd93 into babel:master Jul 2, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.73% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Jul 2, 2018

Thank you! 🙂 (⚰️🎉)

@brainkim

This comment has been minimized.

Copy link

brainkim commented Jul 2, 2018

🎊👅💋🙆‍♀🙇‍♂🦄🌈⭐️🏄‍♂💰🍆💦😓:) thank you!

@johnbuffington johnbuffington deleted the johnbuffington:emoji-removal branch Jul 20, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.