Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pipeline proposal flag in `@babel/parser` #8291

Merged

Conversation

@mAAdhaTTah
Copy link
Contributor

mAAdhaTTah commented Jul 9, 2018

Q                       A
Fixed Issues? N/A
Patch: Bug Fix? No
Major: Breaking Change? Yes
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? No
License MIT

Split from #8289; implements the flag to babylon so babel can move to an RC and still land that PR without shipping breaking changes. Should be easy to rebase this back into the PR.

@mAAdhaTTah mAAdhaTTah mentioned this pull request Jul 9, 2018
2 of 2 tasks complete
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jul 9, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8553/

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Jul 9, 2018

I'd prefer the validation to happen at

export function validatePlugins(plugins: PluginList) {
, so that it is checked even if the pipeline operator isn't actually used.

You can add a getPluginOption util to that file.

@mAAdhaTTah mAAdhaTTah force-pushed the valtech-nyc:add-proposal-flag-to-pipeline-parser-plugin branch 2 times, most recently from d4fdd45 to cf84792 Jul 9, 2018
@mAAdhaTTah mAAdhaTTah force-pushed the valtech-nyc:add-proposal-flag-to-pipeline-parser-plugin branch from cf84792 to fc4ad83 Jul 9, 2018
@mAAdhaTTah

This comment has been minimized.

Copy link
Contributor Author

mAAdhaTTah commented Jul 9, 2018

@hzoo hzoo merged commit 19a1705 into babel:master Jul 9, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.73% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
storyn26383 pushed a commit to UniSharp/babel that referenced this pull request Aug 6, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.