Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching #8327

Merged
merged 3 commits into from Jul 16, 2018

Conversation

@loganfsmyth
Copy link
Member

loganfsmyth commented Jul 14, 2018

Q                       A
Fixed Issues? Fixes #8184
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

With #8184 we cannot use micromatch on a general path string to do pattern matching. Rather than screw around trying to make that work, we've decided to treat strings as paths with extremely simple pattern matching abilities, and if users would like more complex pattern matching we'll leave it to them to use regexes, or to pass function that will be called to validate whether a path matches the desired pattern.

I've included the two commits from #8201 in this to see how it works, but I'll probably drop them once I see how things look. Still seems to be other issues with that, looks like the tests do need to be tweaked for Windows in general.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jul 14, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8622/

@loganfsmyth loganfsmyth force-pushed the loganfsmyth:drop-pattern-matching branch 2 times, most recently from d3e5bea to d7c0f42 Jul 14, 2018
@hzoo
hzoo approved these changes Jul 16, 2018
Copy link
Member

hzoo left a comment

looks good!

Do we want to document somewhere the kind of pattern matching we support on the docs (just */**) and recommendations otherwise?

@hzoo hzoo added this to the Babel 7 RC milestone Jul 16, 2018
@loganfsmyth loganfsmyth force-pushed the loganfsmyth:drop-pattern-matching branch from d7c0f42 to 6d177ba Jul 16, 2018
@loganfsmyth loganfsmyth merged commit 52a5690 into babel:master Jul 16, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.42% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:drop-pattern-matching branch Jul 16, 2018
calebeby added a commit to Pigmice2733/scouting-frontend that referenced this pull request Jul 17, 2018
This Pull Request renovates the package group "babel monorepo".


-   [@​babel/preset-typescript](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/preset-env](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/plugin-transform-react-jsx](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/plugin-proposal-class-properties](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`
-   [@​babel/core](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54`

# Release Notes
<details>
<summary>babel/babel</summary>

### [`v7.0.0-beta.54`](https://github.com/babel/babel/releases/v7.0.0-beta.54)
[Compare Source](babel/babel@v7.0.0-beta.53...v7.0.0-beta.54)
#### v7.0.0-beta.54 (2018-07-16)

> Regarding `babel/babel#8184, we aren't using `micromatch` for paths, just basic `*/**` substitution now. For anything more complicated we will recommend using a regex/.js config.
> There was a bug in the stage presets (`babel/babel#8307), so we just removed the requirements for setting options in the meantime for ease of use. We are removing the Stage presets next anyway. `babel/babel#8293
##### 💥 Breaking Change
* `babel-core`, `babel-register`, `babel-traverse`
  * [#&#8203;8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@&#8203;loganfsmyth])
##### 🐛 Bug Fix
* `babel-core`, `babel-register`, `babel-traverse`
  * [#&#8203;8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@&#8203;loganfsmyth])
* `babel-preset-stage-0`, `babel-preset-stage-1`
  * [#&#8203;8317](`babel/babel#8317) Fix stage-0/1 import of pipeline proposals array. ([@&#8203;mAAdhaTTah])
* `babel-helper-module-transforms`, `babel-plugin-transform-modules-commonjs`
  * [#&#8203;8316](`babel/babel#8316) Ensure that the wildcard interop is used with re-export + default.. ([@&#8203;loganfsmyth])
* `babel-core`
  * [#&#8203;8315](`babel/babel#8315) Remove option-filtering options from the final options results.. ([@&#8203;loganfsmyth])
##### 📝 Documentation
* [#&#8203;8320](`babel/babel#8320) Add link to audio version of song. ([@&#8203;rugk])
##### Committers: 4
- Daniel Tschinder ([danez])
- James DiGioia ([mAAdhaTTah])
- Logan Smyth ([loganfsmyth])
- rugk ([rugk])

---


</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.