Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTreat string ignore/only/test/include/exclude values as paths with only basic pattern matching #8327
+125
−132
Conversation
This comment has been minimized.
This comment has been minimized.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8622/ |
loganfsmyth
force-pushed the
loganfsmyth:drop-pattern-matching
branch
2 times, most recently
from
d3e5bea
to
d7c0f42
|
looks good! Do we want to document somewhere the kind of pattern matching we support on the docs (just |
loganfsmyth
force-pushed the
loganfsmyth:drop-pattern-matching
branch
from
d7c0f42
to
6d177ba
calebeby
added a commit
to Pigmice2733/scouting-frontend
that referenced
this pull request
Jul 17, 2018
This Pull Request renovates the package group "babel monorepo". - [@​babel/preset-typescript](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` - [@​babel/preset-env](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` - [@​babel/plugin-transform-react-jsx](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` - [@​babel/plugin-proposal-class-properties](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` - [@​babel/core](https://github.com/babel/babel) (`devDependencies`): from `7.0.0-beta.53` to `7.0.0-beta.54` # Release Notes <details> <summary>babel/babel</summary> ### [`v7.0.0-beta.54`](https://github.com/babel/babel/releases/v7.0.0-beta.54) [Compare Source](babel/babel@v7.0.0-beta.53...v7.0.0-beta.54) #### v7.0.0-beta.54 (2018-07-16) > Regarding `babel/babel#8184, we aren't using `micromatch` for paths, just basic `*/**` substitution now. For anything more complicated we will recommend using a regex/.js config. > There was a bug in the stage presets (`babel/babel#8307), so we just removed the requirements for setting options in the meantime for ease of use. We are removing the Stage presets next anyway. `babel/babel#8293 #####💥 Breaking Change * `babel-core`, `babel-register`, `babel-traverse` * [#​8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@​loganfsmyth]) #####🐛 Bug Fix * `babel-core`, `babel-register`, `babel-traverse` * [#​8327](`babel/babel#8327) Treat string ignore/only/test/include/exclude values as paths with only basic pattern matching. ([@​loganfsmyth]) * `babel-preset-stage-0`, `babel-preset-stage-1` * [#​8317](`babel/babel#8317) Fix stage-0/1 import of pipeline proposals array. ([@​mAAdhaTTah]) * `babel-helper-module-transforms`, `babel-plugin-transform-modules-commonjs` * [#​8316](`babel/babel#8316) Ensure that the wildcard interop is used with re-export + default.. ([@​loganfsmyth]) * `babel-core` * [#​8315](`babel/babel#8315) Remove option-filtering options from the final options results.. ([@​loganfsmyth]) #####📝 Documentation * [#​8320](`babel/babel#8320) Add link to audio version of song. ([@​rugk]) ##### Committers: 4 - Daniel Tschinder ([danez]) - James DiGioia ([mAAdhaTTah]) - Logan Smyth ([loganfsmyth]) - rugk ([rugk]) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
loganfsmyth commentedJul 14, 2018
•
edited
With #8184 we cannot use micromatch on a general path string to do pattern matching. Rather than screw around trying to make that work, we've decided to treat strings as paths with extremely simple pattern matching abilities, and if users would like more complex pattern matching we'll leave it to them to use regexes, or to pass function that will be called to validate whether a path matches the desired pattern.
I've included the two commits from #8201 in this to see how it works, but I'll probably drop them once I see how things look.Still seems to be other issues with that, looks like the tests do need to be tweaked for Windows in general.