Skip to content

/babel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Babylon plugins for features already merged to the ECMAScript spec #8448

Merged
merged 3 commits into from Nov 5, 2018

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Aug 10, 2018 •
edited

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? 👍
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

These are now enabled by default:

  • objectRestSpread (2018)
  • asyncGenerators (2018)
  • optionalCatchBInding (2019)
  • jsonStrings (2019)

TODO (after this PR):

  • Deprecate the @babel/plugin-syntax-* packages.
  • Deprecate the @babel/plugin-proposal-* packages.
  • Create the @babel/plugin-transform-* packages.
@nicolo-ribaudo
nicolo-ribaudo reviewed Aug 10, 2018
View changes
packages/babel-plugin-syntax-typescript/src/index.js Outdated
"objectRestSpread",
"classProperties",
);
parserOpts.plugins.push("typescript", "classProperties");

This comment has been minimized.

Sign in to view
Copy link
@nicolo-ribaudo

nicolo-ribaudo Aug 10, 2018

Author Member

This is a breaking change if someone uses an older Babylon version. Since we are in RC, I can revert it if you prefer.
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:remove-babylon-plugins branch from 74e2fe8 to a734266 Aug 10, 2018
@babel-bot

This comment has been minimized.

Sign in to view
Copy link
Collaborator

babel-bot commented Aug 10, 2018 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9332/
@babel-bot

This comment has been minimized.

Sign in to view
Copy link
Collaborator

babel-bot commented Aug 10, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8795/
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Sep 3, 2018
Closed
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Sep 13, 2018
Closed
@danez
danez approved these changes Nov 3, 2018
View changes
Copy link
Member

danez left a comment

lgtm, I like keeping stuff in place to avoid the tiny risk of breaking stuff.
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:remove-babylon-plugins branch 2 times, most recently from d1425ef to d80b02a Nov 4, 2018
@existentialism
existentialism approved these changes Nov 5, 2018
View changes
Copy link
Member

existentialism left a comment

👍 w/o breaking change
@nicolo-ribaudo
Remove Babylon plugins for features already merged to the ECMAScript …
d598b38 
…spec

- objectRestSpread (2018)
- asyncGenerators (2018)
- optionalCatchBInding (2019)
- jsonStrings (2019)
@nicolo-ribaudo
Undo breaking change
Loading status checks…
386dea9
@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo:remove-babylon-plugins branch from cbd9e01 to 386dea9 Nov 5, 2018
@nicolo-ribaudo
Fix grammar [skip ci]
35add24
@nicolo-ribaudo nicolo-ribaudo merged commit 24c4901 into babel:master Nov 5, 2018
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:remove-babylon-plugins branch Nov 5, 2018
This was referenced Nov 7, 2018
Merged
Merged
@fregante fregante mentioned this pull request Nov 8, 2018
Merged
sindresorhus added a commit to sindresorhus/refined-github that referenced this pull request Nov 11, 2018
@fregante @sindresorhus
Drop object spread Babel plugin (#1615)
Loading status checks…
c5118b1 
Follows babel/babel#8448

Context in review comment: https://github.com/sindresorhus/refined-github/pull/1449/files#r216110819
This was referenced Nov 12, 2018
Open
Open
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Nov 30, 2018
Closed
0 of 2 tasks complete
@dependencies dependencies bot mentioned this pull request Dec 1, 2018
Open
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism

@danez danez

Assignees
No one assigned
Labels
PR: New Feature 🚀 outdated pkg: parser
Projects
None yet
Milestone
No milestone
4 participants
@nicolo-ribaudo @babel-bot @existentialism @danez
You can’t perform that action at this time.