Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve 'false'-options for disabled plugins/presets. #8474

merged 1 commit into from Aug 19, 2018


Copy link

loganfsmyth commented Aug 15, 2018

Q                       A
Fixed Issues? Fixes #7920
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This moves the check for options === false into the overall config unification, instead of having it be part of loadPartialConfig.


This comment has been minimized.

Copy link

babel-bot commented Aug 15, 2018

Build successful! You can test your changes in the REPL here:

… can use that to toggle behavior.
@loganfsmyth loganfsmyth force-pushed the loganfsmyth:plugin-opts-preserve-false branch from 79e3899 to a5413bf Aug 16, 2018
@loganfsmyth loganfsmyth merged commit ca639b4 into babel:master Aug 19, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
ci/circleci Your tests passed on CircleCI!
codecov/project 80.5% (target 80%)
continuous-integration/travis-ci/pr The Travis CI build passed
@loganfsmyth loganfsmyth deleted the loganfsmyth:plugin-opts-preserve-false branch Aug 19, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
2 participants
You can’t perform that action at this time.