Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose opt-in useESModules:"auto" from transform-runtime to toggle based on 'supportsStaticESM' #8520

Merged
merged 1 commit into from Aug 24, 2018

Conversation

@loganfsmyth
Copy link
Member

loganfsmyth commented Aug 23, 2018

Q                       A
Fixed Issues? Refs #8516
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This doesn't make the behavior the default, but it does implement the automatic behavior requested in #8516, if you opt into it.

See #8516 (comment) for my concerns about making this the default.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Aug 23, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8897/

1 similar comment
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Aug 23, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8897/

@loganfsmyth loganfsmyth changed the title Use supportsStaticESM to toggle runtime module usage. Expose optional useESModules:"auto" from transform-runtime to toggle based on 'supportsStaticESM' Aug 23, 2018
@loganfsmyth loganfsmyth changed the title Expose optional useESModules:"auto" from transform-runtime to toggle based on 'supportsStaticESM' Expose opt-in useESModules:"auto" from transform-runtime to toggle based on 'supportsStaticESM' Aug 23, 2018
@hzoo
hzoo approved these changes Aug 24, 2018
Copy link
Member

hzoo left a comment

hard to keep up with docs haha

@hzoo hzoo added this to the Babel 7 milestone Aug 24, 2018
@loganfsmyth loganfsmyth merged commit 39fa102 into babel:master Aug 24, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.55% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:runtime-module-usage branch Aug 24, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.