Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add access public to all packages [skip ci] #8573

Merged
merged 1 commit into from Aug 29, 2018

Conversation

@hzoo
Copy link
Member

hzoo commented Aug 28, 2018

Not necessary https://docs.npmjs.com/cli/access, as once you publish as public it will be public but if people copy paste to make an new package they might miss this and we will get a publish error later so figured we should.

@xtuc
xtuc approved these changes Aug 29, 2018
@hzoo hzoo merged commit 04d09cc into master Aug 29, 2018
@nicolo-ribaudo nicolo-ribaudo deleted the access-public branch Aug 29, 2018
NMinhNguyen pushed a commit to NMinhNguyen/babel-plugin-transform-destructuring that referenced this pull request Aug 9, 2019
If people copy paste to make an new package they might miss this and we will get a publish error later so figured we should add it to all.
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.