Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[decorators] [typescript] Parse type parameters #8767

Merged

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Sep 25, 2018

Q                       A
Fixed Issues? Fixes #8753
Patch: Bug Fix? y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Sep 25, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9171/

@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented Sep 26, 2018

@babel/typescript Even if TS doesn't support modern decorators, I assume that it is ok to allow type parameters in this position?

@andy-ms
andy-ms approved these changes Oct 1, 2018
@nicolo-ribaudo nicolo-ribaudo merged commit 3c87401 into babel:master Oct 1, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.53% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:decorators-parse-type-parameters branch Oct 1, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.