Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[decorators] Correctly insert _initialize(this) after super(). #8970

Merged

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 4, 2018

Q                       A
Fixed Issues? Fixes #8931, fixes #8808
Patch: Bug Fix? y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This commit fixes to problem:

  1. After super(); statements, _initialize(this) was inserted without
    a trailing semicolon.
  2. (0, super()) causes an infinite recursion.
This commit fixes to problem:
1) After `super();` statements, `_initialize(this)` was inserted without
   a trailing semicolon.
2) `(0, super())` causes an infinite recursion.
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Nov 4, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9323/

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Nov 4, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9322/

@danez
danez approved these changes Nov 6, 2018
@danez danez merged commit b706e34 into babel:master Nov 7, 2018
4 checks passed
4 checks passed
@babel-bot
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
@codecov
codecov/project 80.62% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:decorators-initialize-call-semicolon branch Nov 7, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants