Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename primitive types to reserved types #8984

Merged
merged 1 commit into from Nov 7, 2018
Merged

Rename primitive types to reserved types #8984

merged 1 commit into from Nov 7, 2018

Conversation

@danez
Copy link
Member

@danez danez commented Nov 7, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Not all of the types on the list are primitive anymore. Also flow calls it reserved type.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Nov 7, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9350/

@existentialism existentialism merged commit 343f776 into master Nov 7, 2018
5 checks passed
5 checks passed
@babel-bot
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
@codecov
codecov/project 80.65% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the reserved-type branch Nov 25, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants