Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettier@1.15.1 #9001

Merged
merged 1 commit into from Nov 9, 2018
Merged

prettier@1.15.1 #9001

merged 1 commit into from Nov 9, 2018

Conversation

@existentialism
Copy link
Member

@existentialism existentialism commented Nov 9, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Nov 9, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9364/

: allowedNumericSeparatorSiblings.bin;
? allowedNumericSeparatorSiblings.dec
: radix === 8
? allowedNumericSeparatorSiblings.oct

This comment has been minimized.

@loganfsmyth

loganfsmyth Nov 9, 2018
Member

Hmm, this seems to make some of these solidly unreadable. Can we see if this is expected, or a bug?

This comment has been minimized.

@loganfsmyth

loganfsmyth Nov 9, 2018
Member

Alright, that's life with Prettier then :P I always thought the excessive nesting was a nice reminder that hey nested ternaries are usually a bad idea. Now they are easy to miss. Alas.

@danez
danez approved these changes Nov 9, 2018
@existentialism existentialism merged commit 4f206b2 into master Nov 9, 2018
5 checks passed
5 checks passed
@babel-bot
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
@codecov
codecov/project 80.68% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@existentialism existentialism deleted the bump-prettier branch Nov 9, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants