Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retainLines regression for arrow functions #9003

Merged
merged 1 commit into from Nov 13, 2018

Conversation

@loganfsmyth
Copy link
Member

loganfsmyth commented Nov 9, 2018

Q                       A
Fixed Issues? Fixes #8992
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

#8868 added this logic but didn't consider that the location isn't guaranteed to be known. One day we'll get typechecking to verify this stuff :(

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Nov 9, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9365/

@danez
danez approved these changes Nov 9, 2018
@shaun-sweet

This comment has been minimized.

Copy link

shaun-sweet commented Nov 9, 2018

bump :) i'm wanting this fix to eliminate a lot of failures I'm seeing as a result! Any ideas when this will make it into a release?

@loganfsmyth loganfsmyth merged commit cbbb3c7 into babel:master Nov 13, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.68% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@loganfsmyth loganfsmyth deleted the loganfsmyth:retainLines-regression branch Nov 13, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.