Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser files to have the same API as the nodejs ones #9004

Merged
merged 1 commit into from Nov 9, 2018

Conversation

@danez
Copy link
Member

@danez danez commented Nov 9, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

It seems this was missed when the new apis were added.

I also added the flow workaround to make sure this does not happen in future.

@danez danez requested a review from loganfsmyth Nov 9, 2018
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Nov 9, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9366/

@loganfsmyth
Copy link
Member

@loganfsmyth loganfsmyth commented Nov 9, 2018

Good catch.

@danez danez merged commit 504b331 into master Nov 9, 2018
4 checks passed
4 checks passed
@babel-bot
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@danez danez deleted the fix-browser-files branch Nov 9, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants