Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass rootMode from @babel/node. #9078

Merged
merged 2 commits into from Nov 29, 2018
Merged

Pass rootMode from @babel/node. #9078

merged 2 commits into from Nov 29, 2018

Conversation

@wtgtybhertgeghgtwtg
Copy link
Contributor

@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg commented Nov 25, 2018

Q                       A
Fixed Issues? Fixes #8968 (although it's already closed).
Patch: Bug Fix? No.
Major: Breaking Change? No.
Minor: New Feature? Yes.
Tests Added + Pass? No.
Documentation PR Link
Any Dependency Changes? No.
License MIT

#8660 added support for rootMode for @babel/core and @babel/cli, but it can't be touched from @babel/node. This pretty much copypastes what @babel/cli got.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Nov 25, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9463/

@loganfsmyth loganfsmyth merged commit c4d6f6d into babel:master Nov 29, 2018
4 checks passed
@wtgtybhertgeghgtwtg wtgtybhertgeghgtwtg deleted the babel-node-root-mode branch Nov 29, 2018
@zefexdeveloper
Copy link

@zefexdeveloper zefexdeveloper commented Dec 7, 2018

@wtgtybhertgeghgtwtg @nicolo-ribaudo @loganfsmyth @existentialism It's not working for me, am I doing something wrong? #9137

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants