Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip minifying standalone in non-publish runs #9094

Merged
merged 1 commit into from Nov 28, 2018
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Skip minifying standalone

Also remove unused dependency on uglify js. gulp-uglify uses its own version.
  • Loading branch information
danez committed Nov 27, 2018
commit 23bc697b538f43b0b53a9e04a55c2f564a13a0a8
@@ -115,7 +115,7 @@ prepublish-build:
rm -rf packages/babel-runtime/helpers
rm -rf packages/babel-runtime-corejs2/helpers
rm -rf packages/babel-runtime-corejs2/core-js
BABEL_ENV=production make build-dist
BABEL_ENV=production IS_PUBLISH=true make build-dist
make clone-license

prepublish:
@@ -63,7 +63,6 @@
"rollup-stream": "^1.24.1",
"test262-stream": "^1.2.0",
"through2": "^2.0.0",
"uglify-js": "^2.4.16",
"vinyl-buffer": "^1.0.1",
"vinyl-source-stream": "^2.0.0",
"webpack": "^3.4.1",
@@ -13,6 +13,9 @@

const path = require("path");
const pump = require("pump");
const chalk = require("chalk");
const through = require("through2");
const gutil = require("gulp-util");
const rename = require("gulp-rename");
const RootMostResolvePlugin = require("webpack-dependency-suite")
.RootMostResolvePlugin;
@@ -94,6 +97,30 @@ function webpackBuild(opts) {
});*/
}

function logUglify() {
return through.obj(function(file, enc, callback) {
gutil.log(
`Minifying '${chalk.cyan(
path.relative(path.join(__dirname, ".."), file.path)
)}'...`
);
callback(null, file);
});
}

function logNoUglify() {
return through.obj(function(file, enc, callback) {
gutil.log(
chalk.yellow(
`Skipped minification of '${chalk.cyan(
path.relative(path.join(__dirname, ".."), file.path)
)}' because not publishing`
)
);
callback(null, file);
});
}

function registerStandalonePackageTask(
gulp,
name,
@@ -116,8 +143,9 @@ function registerStandalonePackageTask(
}),
gulp.dest(standalonePath),
].concat(
// Minification is super slow, so we skip it in CI.
process.env.CI ? [] : uglify(),
// Minification is super slow, so we skip it unless we are publishing
process.env.IS_PUBLISH ? logUglify() : logNoUglify(),
process.env.IS_PUBLISH ? uglify() : [],
rename({ extname: ".min.js" }),
gulp.dest(standalonePath)
),
@@ -9357,7 +9357,7 @@ uglify-js@3.3.x, uglify-js@^3.0.5:
commander "~2.14.1"
source-map "~0.6.1"

uglify-js@^2.4.16, uglify-js@^2.6, uglify-js@^2.8.29:
uglify-js@^2.6, uglify-js@^2.8.29:
version "2.8.29"
resolved "https://registry.yarnpkg.com/uglify-js/-/uglify-js-2.8.29.tgz#29c5733148057bb4e1f75df35b7a9cb72e6a59dd"
integrity sha1-KcVzMUgFe7Th913zW3qcty5qWd0=
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.