Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore empty fixture directories and fix fixtures in the parser #9113

Merged
merged 3 commits into from Dec 3, 2018

Conversation

@danez
Copy link
Member

danez commented Dec 2, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Okay this PR started because I was annoyed that sometimes when I added fixtures somewhere but then ended up reverting, the empty folder was keep but the fixture runner was still generating an output.js.

So I went in and changed the behavior of the fixture runner to ignore folders if there is neither input.ext nor exec.js. This is the first commit.

I checked which folders are ignored and noticed that there are some test fixtures in babylon which are never executed because the folder structure was wrong or the files were named incorrectly.

I fixed all of these cases which are in the second commit.

I noticed another potential issue with regular expressions where we do not check if character ranges are valid, but I did not want to dive into this one yet. So the tests for this are currently skipped.

var x = /[\u0063-b]/u; // should error I think

I removed the other change and moved it into a PR #9114

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Dec 2, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9516/

@danez danez force-pushed the danez:fix-empt-fixture-dirs branch from ed85f21 to e61e648 Dec 2, 2018
@danez danez removed the PR: WIP label Dec 2, 2018
@danez danez changed the title Ignore empty fixture directories and correctly parse floats with leading zero Ignore empty fixture directories and fix fixtures in the parser Dec 2, 2018
@danez danez added area: tests and removed pkg: parser labels Dec 2, 2018
Copy link
Member

nicolo-ribaudo left a comment

(I did only review the first commit)

@danez danez merged commit 07eaa3c into babel:master Dec 3, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.64% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danez danez deleted the danez:fix-empt-fixture-dirs branch Dec 3, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.