Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we always use repository versions of babel dependencies in tests #9132

Merged
merged 1 commit into from Dec 5, 2018

Conversation

@danez
Copy link
Member

@danez danez commented Dec 5, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix? n
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This increases the codecoverage around 3% from 80% to 83% in my local testing and ensures we always test with code from our repository and not installed versions in node_modules.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Dec 5, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9554/

@danez danez merged commit 9c45b8f into babel:master Dec 5, 2018
4 checks passed
@danez danez deleted the local-versions branch Dec 5, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants