Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parameter-destructuring in Edge 18 #9140

Merged
merged 2 commits into from Dec 7, 2018
Merged

Conversation

@saschanaz
Copy link
Contributor

@saschanaz saschanaz commented Dec 7, 2018

Q                       A
Fixed Issues? #9139
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT
@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 7, 2018

Could you open two separate PRs?
Also, does (param, {deep = {}}) => {} work on Edge 18?

@saschanaz
Copy link
Contributor Author

@saschanaz saschanaz commented Dec 7, 2018

Also, does (param, {deep = {}}) => {} work on Edge 18?

Yep:

image

@saschanaz saschanaz changed the title Disable transforms for parameters/destructuring in Edge 18 Disable transforms for parameters in Edge 18 Dec 7, 2018
@saschanaz
Copy link
Contributor Author

@saschanaz saschanaz commented Dec 7, 2018

Opened #9143.

@saschanaz saschanaz changed the title Disable transforms for parameters in Edge 18 Disable parameter-destructuring in Edge 18 Dec 7, 2018
@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Dec 7, 2018

Oh I meant one PR for the preset-env update and one for the issue message fix.

@saschanaz
Copy link
Contributor Author

@saschanaz saschanaz commented Dec 7, 2018

Oops, okay!

@saschanaz
Copy link
Contributor Author

@saschanaz saschanaz commented Dec 7, 2018

@nicolo-ribaudo Would you restart the test? Thanks!

Copy link
Member

@existentialism existentialism left a comment

@saschanaz thanks for the PR!

The data for preset-env is directly generated from compat-table, and support for Edge 18 data was merged ~6hrs ago.

Can you update the compat-table hash to the latest (7655c84581184806d4f94ef97fbaac7abd5852d8) in preset/env's package.json, and re-generate the data by running npm run build-data?

@saschanaz
Copy link
Contributor Author

@saschanaz saschanaz commented Dec 7, 2018

Can you update the compat-table hash to the latest

Done! Regeneration didn't cause any diffs 👍

Copy link
Member

@existentialism existentialism left a comment

👍 will merge after CI!

@existentialism existentialism merged commit 4dff205 into babel:master Dec 7, 2018
4 checks passed
@existentialism
Copy link
Member

@existentialism existentialism commented Dec 7, 2018

@saschanaz thanks!

@saschanaz saschanaz deleted the patch-1 branch Dec 7, 2018
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants